refactor scm env vars #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarmatei
commented
Oct 14, 2024
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
There was a problem hiding this comment.
@StalkAltan I don't think we need the above anymore? Since now everything can be configured via the UI integration? (I will add breaking change notes accordingly in the release notes if that's the case)
rarmatei
commented
Oct 14, 2024
| secretKeyRef: | ||
| name: {{ .Values.secret.name }} | ||
| key: {{ .Values.secret.githubAppClientSecret }} | ||
| {{- end }} |
There was a problem hiding this comment.
I'm checking with Mark about these vars: NX_CLOUD_GITHUB_WEBHOOK_SECRET and NX_CLOUD_GITHUB_WEBHOOK_SECRET
- we either need to add them to the docs: https://nx.dev/ci/recipes/enterprise/on-premise/custom-github-app#using-helm
- or we don't need them in here
stevepentland
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.